acctests: Ignore data sources in imported state in ImportState steps
#1074
+30
−32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gdavison
changed the title
ImportStateVerify stepsImportState steps
bendbennett
reviewed
Oct 6, 2022
There was a problem hiding this comment.
Looks good @gdavison.
Could you possibly add a test, perhaps to teststep_providers_test.go, to verify the behaviour? Thanks.
Amad3eu
approved these changes
Oct 7, 2022
bendbennett
added a commit
that referenced
this pull request
Oct 10, 2022
bflad
added
bug
bflad
approved these changes
Oct 10, 2022
| @@ -26,7 +26,7 @@ require ( | |||
| github.com/mitchellh/reflectwalk v1.0.2 | |||
| github.com/zclconf/go-cty v1.11.0 | |||
| golang.org/x/crypto v0.0.0-20220517005047-85d78b3ac167 | |||
| golang.org/x/tools v0.0.0-20200713011307-fd294ab11aed | |||
| golang.org/x/tools v0.1.12 | |||
There was a problem hiding this comment.
Was this change required for some reason?
There was a problem hiding this comment.
It's not directly related to this fix, but was required to run make generate which is a dependency for make test.
bendbennett
added a commit
that referenced
this pull request
Oct 12, 2022
bendbennett
added a commit
that referenced
this pull request
Oct 13, 2022
…tate (#1077) * Adding test coverage for changes in #1074 (#1066) * Skips data sources from both original state and imported state * Adding changelog entry (#1066) Co-authored-by: Graham Davison <[email protected]>
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Starting with Terraform v1.3, the
terraform importcommand populates an empty state file with the imported resource and any data sources. Previously, only the target resource was written to the state file. This causes acceptance test steps withImportStateto fail if the configuration contains any data sources.Excludes data sources from both original state and imported state
Closes #1073
Closes #1066